Compare commits
9 Commits
feat/kill-
...
19e83ff8ba
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
19e83ff8ba | ||
| 2a6413821a | |||
| 008435f1c2 | |||
| 354ba9227e | |||
| 2de3212210 | |||
| 86e9a49c08 | |||
|
|
89c873b368 | ||
|
|
4fc5b902c4 | ||
|
|
72dcd396f8 |
@@ -11,6 +11,7 @@ const MAIN = join(here, '..', 'out', 'main', 'index.js')
|
|||||||
test.describe('live backlog', () => {
|
test.describe('live backlog', () => {
|
||||||
test('The pot + Focus render real gitea data', async () => {
|
test('The pot + Focus render real gitea data', async () => {
|
||||||
test.skip(!process.env.GITEA_LIVE, 'GITEA_LIVE not set — opt-in live test')
|
test.skip(!process.env.GITEA_LIVE, 'GITEA_LIVE not set — opt-in live test')
|
||||||
|
test.setTimeout(90_000)
|
||||||
const app = await electron.launch({ args: [MAIN], env: { ...process.env } })
|
const app = await electron.launch({ args: [MAIN], env: { ...process.env } })
|
||||||
const win = await app.firstWindow()
|
const win = await app.firstWindow()
|
||||||
await win.waitForLoadState('domcontentloaded')
|
await win.waitForLoadState('domcontentloaded')
|
||||||
@@ -42,16 +43,17 @@ test.describe('live backlog', () => {
|
|||||||
win.getByText(/cold-start priors · \d+\/20 closed issues estimated|calibrated on \d+ closed/),
|
win.getByText(/cold-start priors · \d+\/20 closed issues estimated|calibrated on \d+ closed/),
|
||||||
).toBeVisible()
|
).toBeVisible()
|
||||||
// Real per-milestone forecasts — these milestone names come from gitea, not the
|
// Real per-milestone forecasts — these milestone names come from gitea, not the
|
||||||
// fixture (which lists Beta / Pilot-ready / v1.0).
|
// fixture (Beta / Pilot-ready / v1.0). The runway shows milestones with open
|
||||||
await expect(win.getByText(/P2 — Scheduler/)).toBeVisible()
|
// scope; P5 is active (P2 is fully shipped, so it's correctly omitted).
|
||||||
|
await expect(win.getByText(/P5 — Dogfood/)).toBeVisible()
|
||||||
// Real capacity config from pm-state (christian/stephen), not the fixture (Stephen/Ana K.)
|
// Real capacity config from pm-state (christian/stephen), not the fixture (Stephen/Ana K.)
|
||||||
await expect(win.getByText('christian', { exact: true })).toBeVisible()
|
await expect(win.getByText('christian', { exact: true })).toBeVisible()
|
||||||
await expect(win.getByText(/pd\/day/).first()).toBeVisible()
|
await expect(win.getByText(/pd\/day/).first()).toBeVisible()
|
||||||
await win.screenshot({ path: join(here, '.artifacts', 'screens', 'live-runway.png'), fullPage: true, animations: 'disabled' })
|
await win.screenshot({ path: join(here, '.artifacts', 'screens', 'live-runway.png'), fullPage: true, animations: 'disabled' })
|
||||||
|
|
||||||
// Milestone drill-in — clicking a real milestone opens its real detail
|
// Milestone drill-in — clicking a real (active) milestone opens its real detail
|
||||||
await win.getByText(/P2 — Scheduler/).click()
|
await win.getByText(/P5 — Dogfood/).click()
|
||||||
await expect(win.getByRole('heading', { name: 'P2 — Scheduler + Monte Carlo' })).toBeVisible()
|
await expect(win.getByRole('heading', { name: 'P5 — Dogfood + polish' })).toBeVisible()
|
||||||
await expect(win.getByText(/\d+ issues · est \d+d/)).toBeVisible()
|
await expect(win.getByText(/\d+ issues · est \d+d/)).toBeVisible()
|
||||||
await win.screenshot({ path: join(here, '.artifacts', 'screens', 'live-milestone.png'), fullPage: true, animations: 'disabled' })
|
await win.screenshot({ path: join(here, '.artifacts', 'screens', 'live-milestone.png'), fullPage: true, animations: 'disabled' })
|
||||||
await rail.getByRole('button', { name: 'Runway' }).click()
|
await rail.getByRole('button', { name: 'Runway' }).click()
|
||||||
@@ -68,10 +70,15 @@ test.describe('live backlog', () => {
|
|||||||
await win.getByRole('main').getByRole('link').first().click()
|
await win.getByRole('main').getByRole('link').first().click()
|
||||||
await expect(win.getByText(/· stephen\/commitea/)).toBeVisible()
|
await expect(win.getByText(/· stephen\/commitea/)).toBeVisible()
|
||||||
await win.getByRole('button', { name: 'Adjust' }).click()
|
await win.getByRole('button', { name: 'Adjust' }).click()
|
||||||
await expect(win.getByText('Adjust estimate & priority')).toBeVisible()
|
await expect(win.getByText('Adjust issue')).toBeVisible()
|
||||||
await win.getByRole('combobox').first().selectOption('est/8d')
|
await win.getByRole('combobox').first().selectOption('est/8d')
|
||||||
await expect(win.getByText('Proposed label change')).toBeVisible()
|
await expect(win.getByText('Proposed change')).toBeVisible()
|
||||||
await expect(win.getByText(/est\/8d/).last()).toBeVisible()
|
await expect(win.getByText(/est\/8d/).last()).toBeVisible()
|
||||||
|
// the unified tool also drives assignee + milestone — the pickers render and diff
|
||||||
|
await expect(win.getByText('Assignee', { exact: true })).toBeVisible()
|
||||||
|
await expect(win.getByText('Milestone', { exact: true })).toBeVisible()
|
||||||
|
await win.getByRole('combobox').nth(2).selectOption('') // Assignee → Unassigned
|
||||||
|
await expect(win.getByText('unassign', { exact: true })).toBeVisible()
|
||||||
await win.screenshot({ path: join(here, '.artifacts', 'screens', 'live-apply-change.png'), fullPage: true, animations: 'disabled' })
|
await win.screenshot({ path: join(here, '.artifacts', 'screens', 'live-apply-change.png'), fullPage: true, animations: 'disabled' })
|
||||||
await win.getByRole('button', { name: 'Cancel' }).click() // no mutation
|
await win.getByRole('button', { name: 'Cancel' }).click() // no mutation
|
||||||
|
|
||||||
|
|||||||
@@ -19,6 +19,7 @@ import {
|
|||||||
type GiteaConfig,
|
type GiteaConfig,
|
||||||
type GiteaLabel,
|
type GiteaLabel,
|
||||||
type IssueChange,
|
type IssueChange,
|
||||||
|
isLabelChange,
|
||||||
type LifecycleEvent,
|
type LifecycleEvent,
|
||||||
makeDirectiveEntry,
|
makeDirectiveEntry,
|
||||||
parseCapacityConfig,
|
parseCapacityConfig,
|
||||||
@@ -263,19 +264,32 @@ export function registerGiteaIpc(): void {
|
|||||||
return client.getIssue(index)
|
return client.getIssue(index)
|
||||||
})
|
})
|
||||||
|
|
||||||
// The write path (apply_changes). Additive label swaps, applied only after the
|
// The write path (apply_changes), applied only after the renderer's propose-
|
||||||
// renderer's propose-approve. Returns the plan + the freshly-read issue.
|
// approve. Label swaps (est/p) return the plan; field writes (assign, milestone)
|
||||||
|
// return the freshly-read issue directly. Either way the snapshot is invalidated
|
||||||
|
// so the board + forecast reflect the change.
|
||||||
ipcMain.handle('gitea:applyChange', async (_event, change: IssueChange) => {
|
ipcMain.handle('gitea:applyChange', async (_event, change: IssueChange) => {
|
||||||
const client = getGiteaClient()
|
const client = getGiteaClient()
|
||||||
if (!client) return { ok: false as const, reason: 'unconfigured' as const }
|
if (!client) return { ok: false as const, reason: 'unconfigured' as const }
|
||||||
|
|
||||||
|
if (isLabelChange(change)) {
|
||||||
const current = await client.getIssue(change.issue)
|
const current = await client.getIssue(change.issue)
|
||||||
const plan = planIssueChange(current.labels, change)
|
const plan = planIssueChange(current.labels, change)
|
||||||
if (plan.noop) return { ok: true as const, plan, issue: current }
|
if (plan.noop) return { ok: true as const, plan, issue: current }
|
||||||
const ids = await resolveLabelIds(client, plan.labels)
|
const ids = await resolveLabelIds(client, plan.labels)
|
||||||
await client.setIssueLabels(change.issue, ids)
|
await client.setIssueLabels(change.issue, ids)
|
||||||
const issue = await client.getIssue(change.issue)
|
const issue = await client.getIssue(change.issue)
|
||||||
invalidateSnapshot() // the board + forecast must reflect the label change
|
invalidateSnapshot()
|
||||||
return { ok: true as const, plan, issue }
|
return { ok: true as const, plan, issue }
|
||||||
|
}
|
||||||
|
|
||||||
|
// Field writes — the client returns the updated issue.
|
||||||
|
const issue =
|
||||||
|
change.kind === 'assign'
|
||||||
|
? await client.setIssueAssignees(change.issue, change.assignee ? [change.assignee] : [])
|
||||||
|
: await client.setIssueMilestone(change.issue, change.milestone)
|
||||||
|
invalidateSnapshot()
|
||||||
|
return { ok: true as const, issue }
|
||||||
})
|
})
|
||||||
|
|
||||||
// capture_work filing: open each approved issue with its est/* + p/* labels.
|
// capture_work filing: open each approved issue with its est/* + p/* labels.
|
||||||
@@ -319,6 +333,17 @@ export function registerGiteaIpc(): void {
|
|||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// Assignable people (repo collaborators) for the Adjust dialog's assignee picker.
|
||||||
|
ipcMain.handle('gitea:collaborators', async () => {
|
||||||
|
const client = getGiteaClient()
|
||||||
|
if (!client) return []
|
||||||
|
try {
|
||||||
|
return await client.listCollaborators()
|
||||||
|
} catch {
|
||||||
|
return []
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
// ---- config (team onboarding) ----
|
// ---- config (team onboarding) ----
|
||||||
ipcMain.handle('config:get', () => publicConfig())
|
ipcMain.handle('config:get', () => publicConfig())
|
||||||
|
|
||||||
|
|||||||
@@ -13,7 +13,6 @@ import {
|
|||||||
type ChangeProposal,
|
type ChangeProposal,
|
||||||
type ChatMessage,
|
type ChatMessage,
|
||||||
createChatClient,
|
createChatClient,
|
||||||
describeChange,
|
|
||||||
type ModelRouter,
|
type ModelRouter,
|
||||||
type ProjectView,
|
type ProjectView,
|
||||||
proposalsFor,
|
proposalsFor,
|
||||||
@@ -130,10 +129,19 @@ export function registerModelIpc(): void {
|
|||||||
const a = (args ?? {}) as ProposeChangeArgs
|
const a = (args ?? {}) as ProposeChangeArgs
|
||||||
const issue = await client.getIssue(a.issue).catch(() => null)
|
const issue = await client.getIssue(a.issue).catch(() => null)
|
||||||
if (!issue) return { error: `issue #${a.issue} not found` }
|
if (!issue) return { error: `issue #${a.issue} not found` }
|
||||||
const built = proposalsFor(a, issue.labels, issue.title)
|
// Milestone titles + current assignee/milestone let a proposal label the
|
||||||
|
// milestone and skip a no-op assign/move.
|
||||||
|
const milestones = (a.milestone !== undefined ? await client.listMilestones().catch(() => []) : []).map(
|
||||||
|
(m) => ({ id: m.id, title: m.title }),
|
||||||
|
)
|
||||||
|
const built = proposalsFor(a, issue.labels, issue.title, {
|
||||||
|
currentAssignee: issue.assignee,
|
||||||
|
currentMilestoneId: issue.milestone?.id ?? null,
|
||||||
|
milestones,
|
||||||
|
})
|
||||||
proposals.push(...built)
|
proposals.push(...built)
|
||||||
return built.length
|
return built.length
|
||||||
? { proposed: built.map((p) => ({ issue: a.issue, diff: describeChange(p.plan) })) }
|
? { proposed: built.map((p) => ({ issue: a.issue, diff: p.summary })) }
|
||||||
: { proposed: [], note: 'no change — already at that value' }
|
: { proposed: [], note: 'no change — already at that value' }
|
||||||
}
|
}
|
||||||
if (name === 'record_directive') {
|
if (name === 'record_directive') {
|
||||||
|
|||||||
@@ -15,6 +15,8 @@ const api = {
|
|||||||
applyChange: (change: unknown) => ipcRenderer.invoke('gitea:applyChange', change),
|
applyChange: (change: unknown) => ipcRenderer.invoke('gitea:applyChange', change),
|
||||||
/** File a set of captured issues with their est/* + p/* labels. */
|
/** File a set of captured issues with their est/* + p/* labels. */
|
||||||
createIssues: (issues: unknown) => ipcRenderer.invoke('gitea:createIssues', issues),
|
createIssues: (issues: unknown) => ipcRenderer.invoke('gitea:createIssues', issues),
|
||||||
|
/** Assignable people (repo collaborators) for the assignee picker. */
|
||||||
|
collaborators: () => ipcRenderer.invoke('gitea:collaborators'),
|
||||||
},
|
},
|
||||||
pmstate: {
|
pmstate: {
|
||||||
/** Read the directive ledger from the pm-state repo. */
|
/** Read the directive ledger from the pm-state repo. */
|
||||||
|
|||||||
@@ -178,6 +178,9 @@ export function CalibrationScreen({ onBack, data }: { onBack: () => void; data?:
|
|||||||
{c.active
|
{c.active
|
||||||
? 'You are not bad at estimating; you are optimistic in a very stable way. Stable, I can work with.'
|
? 'You are not bad at estimating; you are optimistic in a very stable way. Stable, I can work with.'
|
||||||
: 'Not enough closed history yet — I’m forecasting from cold-start priors and widening the cone to stay honest. The curve takes over at 20.'}
|
: 'Not enough closed history yet — I’m forecasting from cold-start priors and widening the cone to stay honest. The curve takes over at 20.'}
|
||||||
|
{!c.active && c.excludedSameDay > 0
|
||||||
|
? ` And ${c.excludedSameDay} closed ${c.excludedSameDay === 1 ? 'issue' : 'issues'} closed the same day they were started — 0 working days can’t calibrate, so they don’t count toward the 20.`
|
||||||
|
: ''}
|
||||||
</p>
|
</p>
|
||||||
</Card>
|
</Card>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -2,13 +2,12 @@
|
|||||||
import React, { useState } from 'react'
|
import React, { useState } from 'react'
|
||||||
|
|
||||||
import {
|
import {
|
||||||
describeChange,
|
|
||||||
type EstimateLabel,
|
type EstimateLabel,
|
||||||
ESTIMATE_LABELS,
|
ESTIMATE_LABELS,
|
||||||
type IssueChange,
|
type IssueChange,
|
||||||
planIssueChange,
|
|
||||||
type PriorityLabel,
|
type PriorityLabel,
|
||||||
PRIORITY_LABELS,
|
PRIORITY_LABELS,
|
||||||
|
summarizeChange,
|
||||||
} from '@commitea/core'
|
} from '@commitea/core'
|
||||||
|
|
||||||
import { ISSUE_DETAIL, type IssueDetail, type IssueRef } from '../../data/fixtures.js'
|
import { ISSUE_DETAIL, type IssueDetail, type IssueRef } from '../../data/fixtures.js'
|
||||||
@@ -23,6 +22,10 @@ export function IssueScreen({
|
|||||||
onOpenIssue,
|
onOpenIssue,
|
||||||
canWrite = false,
|
canWrite = false,
|
||||||
onApplyChange,
|
onApplyChange,
|
||||||
|
collaborators = [],
|
||||||
|
milestones = [],
|
||||||
|
currentAssignee = null,
|
||||||
|
currentMilestoneId = null,
|
||||||
}: {
|
}: {
|
||||||
issue: IssueRef
|
issue: IssueRef
|
||||||
detail?: IssueDetail
|
detail?: IssueDetail
|
||||||
@@ -30,6 +33,10 @@ export function IssueScreen({
|
|||||||
onOpenIssue: (issue: IssueRef) => void
|
onOpenIssue: (issue: IssueRef) => void
|
||||||
canWrite?: boolean
|
canWrite?: boolean
|
||||||
onApplyChange?: (change: IssueChange) => Promise<{ ok: boolean }>
|
onApplyChange?: (change: IssueChange) => Promise<{ ok: boolean }>
|
||||||
|
collaborators?: { login: string; name: string }[]
|
||||||
|
milestones?: { id: number; title: string }[]
|
||||||
|
currentAssignee?: string | null
|
||||||
|
currentMilestoneId?: number | null
|
||||||
}) {
|
}) {
|
||||||
const det: IssueDetail = detail ?? ISSUE_DETAIL[issue.id] ?? {
|
const det: IssueDetail = detail ?? ISSUE_DETAIL[issue.id] ?? {
|
||||||
state: 'triage',
|
state: 'triage',
|
||||||
@@ -62,25 +69,40 @@ export function IssueScreen({
|
|||||||
const labels = issue.labels ?? []
|
const labels = issue.labels ?? []
|
||||||
const curEstimate = labels.find((l) => l.startsWith('est/')) ?? ''
|
const curEstimate = labels.find((l) => l.startsWith('est/')) ?? ''
|
||||||
const curPriority = labels.find((l) => l.startsWith('p/')) ?? ''
|
const curPriority = labels.find((l) => l.startsWith('p/')) ?? ''
|
||||||
|
const curAssignee = currentAssignee ?? ''
|
||||||
|
const curMilestone = currentMilestoneId != null ? String(currentMilestoneId) : ''
|
||||||
const [adjustOpen, setAdjustOpen] = useState(false)
|
const [adjustOpen, setAdjustOpen] = useState(false)
|
||||||
const [estimate, setEstimate] = useState(curEstimate)
|
const [estimate, setEstimate] = useState(curEstimate)
|
||||||
const [priority, setPriority] = useState(curPriority)
|
const [priority, setPriority] = useState(curPriority)
|
||||||
|
const [assignee, setAssignee] = useState(curAssignee)
|
||||||
|
const [milestone, setMilestone] = useState(curMilestone)
|
||||||
const [applying, setApplying] = useState(false)
|
const [applying, setApplying] = useState(false)
|
||||||
|
|
||||||
const openAdjust = () => {
|
const openAdjust = () => {
|
||||||
setEstimate(curEstimate)
|
setEstimate(curEstimate)
|
||||||
setPriority(curPriority)
|
setPriority(curPriority)
|
||||||
|
setAssignee(curAssignee)
|
||||||
|
setMilestone(curMilestone)
|
||||||
setAdjustOpen(true)
|
setAdjustOpen(true)
|
||||||
}
|
}
|
||||||
|
|
||||||
// the concrete changes this dialog would apply, one per axis that differs
|
// the concrete changes this dialog would apply, one per field that differs
|
||||||
const pendingChanges: IssueChange[] = []
|
const pendingChanges: IssueChange[] = []
|
||||||
if (estimate !== curEstimate)
|
if (estimate !== curEstimate)
|
||||||
pendingChanges.push({ kind: 'reestimate', issue: issue.id, estimate: (estimate || null) as EstimateLabel | null })
|
pendingChanges.push({ kind: 'reestimate', issue: issue.id, estimate: (estimate || null) as EstimateLabel | null })
|
||||||
if (priority !== curPriority)
|
if (priority !== curPriority)
|
||||||
pendingChanges.push({ kind: 'reprioritize', issue: issue.id, priority: (priority || null) as PriorityLabel | null })
|
pendingChanges.push({ kind: 'reprioritize', issue: issue.id, priority: (priority || null) as PriorityLabel | null })
|
||||||
|
if (assignee !== curAssignee)
|
||||||
|
pendingChanges.push({ kind: 'assign', issue: issue.id, assignee: assignee || null })
|
||||||
|
if (milestone !== curMilestone)
|
||||||
|
pendingChanges.push({
|
||||||
|
kind: 'remilestone',
|
||||||
|
issue: issue.id,
|
||||||
|
milestone: milestone ? Number(milestone) : null,
|
||||||
|
milestoneTitle: milestones.find((m) => String(m.id) === milestone)?.title ?? null,
|
||||||
|
})
|
||||||
|
|
||||||
const diffs = pendingChanges.map((c) => describeChange(planIssueChange(labels, c)))
|
const diffs = pendingChanges.map((c) => summarizeChange(c, labels))
|
||||||
|
|
||||||
const apply = async () => {
|
const apply = async () => {
|
||||||
if (!onApplyChange || pendingChanges.length === 0) return
|
if (!onApplyChange || pendingChanges.length === 0) return
|
||||||
@@ -95,6 +117,14 @@ export function IssueScreen({
|
|||||||
|
|
||||||
const estOptions = [{ value: '', label: NONE }, ...ESTIMATE_LABELS.map((l) => ({ value: l, label: l }))]
|
const estOptions = [{ value: '', label: NONE }, ...ESTIMATE_LABELS.map((l) => ({ value: l, label: l }))]
|
||||||
const prioOptions = [{ value: '', label: NONE }, ...PRIORITY_LABELS.map((l) => ({ value: l, label: l }))]
|
const prioOptions = [{ value: '', label: NONE }, ...PRIORITY_LABELS.map((l) => ({ value: l, label: l }))]
|
||||||
|
const assigneeOptions = [
|
||||||
|
{ value: '', label: 'Unassigned' },
|
||||||
|
...collaborators.map((c) => ({ value: c.login, label: c.name })),
|
||||||
|
]
|
||||||
|
const milestoneOptions = [
|
||||||
|
{ value: '', label: NONE },
|
||||||
|
...milestones.map((m) => ({ value: String(m.id), label: m.title })),
|
||||||
|
]
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div style={{ display: 'flex', flexDirection: 'column', gap: 16 }}>
|
<div style={{ display: 'flex', flexDirection: 'column', gap: 16 }}>
|
||||||
@@ -135,7 +165,7 @@ export function IssueScreen({
|
|||||||
<Dialog
|
<Dialog
|
||||||
open={adjustOpen}
|
open={adjustOpen}
|
||||||
onClose={() => setAdjustOpen(false)}
|
onClose={() => setAdjustOpen(false)}
|
||||||
title="Adjust estimate & priority"
|
title="Adjust issue"
|
||||||
footer={
|
footer={
|
||||||
<>
|
<>
|
||||||
<Button variant="ghost" onClick={() => setAdjustOpen(false)}>
|
<Button variant="ghost" onClick={() => setAdjustOpen(false)}>
|
||||||
@@ -161,15 +191,35 @@ export function IssueScreen({
|
|||||||
onChange={(e) => setPriority(e.target.value)}
|
onChange={(e) => setPriority(e.target.value)}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
{(collaborators.length > 0 || milestones.length > 0) && (
|
||||||
|
<div style={{ display: 'flex', gap: 14, marginTop: 12 }}>
|
||||||
|
{collaborators.length > 0 ? (
|
||||||
|
<Select
|
||||||
|
label="Assignee"
|
||||||
|
options={assigneeOptions}
|
||||||
|
value={assignee}
|
||||||
|
onChange={(e) => setAssignee(e.target.value)}
|
||||||
|
/>
|
||||||
|
) : null}
|
||||||
|
{milestones.length > 0 ? (
|
||||||
|
<Select
|
||||||
|
label="Milestone"
|
||||||
|
options={milestoneOptions}
|
||||||
|
value={milestone}
|
||||||
|
onChange={(e) => setMilestone(e.target.value)}
|
||||||
|
/>
|
||||||
|
) : null}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
<div style={{ marginTop: 14, minHeight: 40 }}>
|
<div style={{ marginTop: 14, minHeight: 40 }}>
|
||||||
{pendingChanges.length === 0 ? (
|
{pendingChanges.length === 0 ? (
|
||||||
<p style={{ font: 'var(--text-agent)', color: 'var(--ink-3)', margin: 0 }}>
|
<p style={{ font: 'var(--text-agent)', color: 'var(--ink-3)', margin: 0 }}>
|
||||||
No change yet — pick a different estimate or priority.
|
No change yet — pick a different estimate, priority, assignee, or milestone.
|
||||||
</p>
|
</p>
|
||||||
) : (
|
) : (
|
||||||
<>
|
<>
|
||||||
<p style={{ font: 'var(--text-overline)', letterSpacing: 'var(--letter-spacing-wide)', textTransform: 'uppercase', color: 'var(--ink-3)', margin: '0 0 6px' }}>
|
<p style={{ font: 'var(--text-overline)', letterSpacing: 'var(--letter-spacing-wide)', textTransform: 'uppercase', color: 'var(--ink-3)', margin: '0 0 6px' }}>
|
||||||
Proposed label change
|
Proposed change
|
||||||
</p>
|
</p>
|
||||||
{diffs.map((d) => (
|
{diffs.map((d) => (
|
||||||
<div key={d} style={{ font: '500 13px var(--font-mono)', color: 'var(--ink-1)' }}>
|
<div key={d} style={{ font: '500 13px var(--font-mono)', color: 'var(--ink-1)' }}>
|
||||||
@@ -177,7 +227,7 @@ export function IssueScreen({
|
|||||||
</div>
|
</div>
|
||||||
))}
|
))}
|
||||||
<p style={{ font: 'var(--text-agent)', color: 'var(--ink-2)', margin: '8px 0 0' }}>
|
<p style={{ font: 'var(--text-agent)', color: 'var(--ink-2)', margin: '8px 0 0' }}>
|
||||||
Writes the label to gitea and re-runs the plan. Nothing else changes.
|
Writes to gitea and re-runs the plan. Nothing else changes.
|
||||||
</p>
|
</p>
|
||||||
</>
|
</>
|
||||||
)}
|
)}
|
||||||
|
|||||||
@@ -17,7 +17,7 @@ export function RunwayScreen({
|
|||||||
}: {
|
}: {
|
||||||
onOpenCalibration: () => void
|
onOpenCalibration: () => void
|
||||||
onOpenMilestone: (id?: number) => void
|
onOpenMilestone: (id?: number) => void
|
||||||
calibration?: { n: number; coldStart: boolean }
|
calibration?: { n: number; coldStart: boolean; excludedSameDay?: number }
|
||||||
milestones?: RunwayMilestone[]
|
milestones?: RunwayMilestone[]
|
||||||
capacity?: CapacityMember[]
|
capacity?: CapacityMember[]
|
||||||
}) {
|
}) {
|
||||||
@@ -30,9 +30,11 @@ export function RunwayScreen({
|
|||||||
hours: `${capacityPerWorkday(m).toFixed(2)} pd/day`,
|
hours: `${capacityPerWorkday(m).toFixed(2)} pd/day`,
|
||||||
}))
|
}))
|
||||||
: CAPACITY
|
: CAPACITY
|
||||||
|
const excluded = calibration?.excludedSameDay ?? 0
|
||||||
const calibNote = calibration
|
const calibNote = calibration
|
||||||
? calibration.coldStart
|
? calibration.coldStart
|
||||||
? `cold-start priors · ${calibration.n}/20 closed issues estimated`
|
? `cold-start priors · ${calibration.n}/20 closed issues estimated` +
|
||||||
|
(excluded > 0 ? ` · ${excluded} same-day close${excluded === 1 ? '' : 's'} can’t calibrate` : '')
|
||||||
: `calibrated on ${calibration.n} closed ${calibration.n === 1 ? 'issue' : 'issues'}`
|
: `calibrated on ${calibration.n} closed ${calibration.n === 1 ? 'issue' : 'issues'}`
|
||||||
: 'calibrated on 27 closed issues'
|
: 'calibrated on 27 closed issues'
|
||||||
return (
|
return (
|
||||||
|
|||||||
@@ -108,6 +108,7 @@ export function AppShell() {
|
|||||||
const [gate, setGate] = useState<'checking' | 'connect' | 'ready'>('checking')
|
const [gate, setGate] = useState<'checking' | 'connect' | 'ready'>('checking')
|
||||||
const [demo, setDemo] = useState(false)
|
const [demo, setDemo] = useState(false)
|
||||||
const [pubConfig, setPubConfig] = useState<PublicConfig | null>(null)
|
const [pubConfig, setPubConfig] = useState<PublicConfig | null>(null)
|
||||||
|
const [collaborators, setCollaborators] = useState<{ login: string; name: string }[]>([])
|
||||||
const [backlog, refetchBacklog] = useBacklog()
|
const [backlog, refetchBacklog] = useBacklog()
|
||||||
const capacityMembers = useCapacity()
|
const capacityMembers = useCapacity()
|
||||||
const workers = capacityWorkers(capacityMembers)
|
const workers = capacityWorkers(capacityMembers)
|
||||||
@@ -189,8 +190,17 @@ export function AppShell() {
|
|||||||
})
|
})
|
||||||
.catch(() => setGate('connect'))
|
.catch(() => setGate('connect'))
|
||||||
window.commitea.config.get().then(setPubConfig).catch(() => {})
|
window.commitea.config.get().then(setPubConfig).catch(() => {})
|
||||||
|
// Assignable people for the Adjust dialog's assignee picker (empty when demo/unconfigured).
|
||||||
|
window.commitea.gitea.collaborators().then(setCollaborators).catch(() => {})
|
||||||
}, [])
|
}, [])
|
||||||
|
|
||||||
|
// The open issue's current assignee + milestone (from the reconciled backlog),
|
||||||
|
// so the Adjust dialog can preselect and diff them. Milestones list feeds its picker.
|
||||||
|
const currentIssue =
|
||||||
|
backlog.status === 'ready' && issue ? backlog.issues.find((i) => i.number === issue.id) : undefined
|
||||||
|
const milestoneOptions =
|
||||||
|
backlog.status === 'ready' ? backlog.milestones.map((m) => ({ id: m.id, title: m.title })) : []
|
||||||
|
|
||||||
const openIssue = (ref: IssueRef) => {
|
const openIssue = (ref: IssueRef) => {
|
||||||
if (view !== 'issue') setPrevView(view)
|
if (view !== 'issue') setPrevView(view)
|
||||||
// Callers into the sidecar (e.g. a "blocks #N" chip) may know only the id.
|
// Callers into the sidecar (e.g. a "blocks #N" chip) may know only the id.
|
||||||
@@ -296,7 +306,15 @@ export function AppShell() {
|
|||||||
setMilestoneId(id ?? null)
|
setMilestoneId(id ?? null)
|
||||||
setView('milestone')
|
setView('milestone')
|
||||||
}}
|
}}
|
||||||
calibration={calibration ? { n: calibration.model.n, coldStart: calibration.model.coldStart } : undefined}
|
calibration={
|
||||||
|
calibration
|
||||||
|
? {
|
||||||
|
n: calibration.model.n,
|
||||||
|
coldStart: calibration.model.coldStart,
|
||||||
|
excludedSameDay: calibration.coverage.excludedSameDay,
|
||||||
|
}
|
||||||
|
: undefined
|
||||||
|
}
|
||||||
milestones={runwayMilestones}
|
milestones={runwayMilestones}
|
||||||
capacity={capacityMembers}
|
capacity={capacityMembers}
|
||||||
/>
|
/>
|
||||||
@@ -343,6 +361,10 @@ export function AppShell() {
|
|||||||
onOpenIssue={openIssue}
|
onOpenIssue={openIssue}
|
||||||
canWrite={backlog.status === 'ready'}
|
canWrite={backlog.status === 'ready'}
|
||||||
onApplyChange={applyChange}
|
onApplyChange={applyChange}
|
||||||
|
collaborators={collaborators}
|
||||||
|
milestones={milestoneOptions}
|
||||||
|
currentAssignee={currentIssue?.assignee ?? null}
|
||||||
|
currentMilestoneId={currentIssue?.milestone?.id ?? null}
|
||||||
/>
|
/>
|
||||||
) : null
|
) : null
|
||||||
case 'states':
|
case 'states':
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
import React, { useEffect, useRef, useState } from 'react'
|
import React, { useEffect, useRef, useState } from 'react'
|
||||||
|
|
||||||
import { describeChange, type IssueChange } from '@commitea/core'
|
import type { IssueChange } from '@commitea/core'
|
||||||
|
|
||||||
import { useChat } from '../../lib/use-chat.js'
|
import { useChat } from '../../lib/use-chat.js'
|
||||||
import { Button, Icon, IconButton } from '../ui/index.js'
|
import { Button, Icon, IconButton } from '../ui/index.js'
|
||||||
@@ -127,7 +127,7 @@ export function ChatPanel({ onOpenDirectives, offline, onApplyChange }: ChatPane
|
|||||||
<div style={{ font: 'var(--text-caption)', color: 'var(--ink-3)', textTransform: 'uppercase', letterSpacing: 'var(--letter-spacing-wide)' }}>
|
<div style={{ font: 'var(--text-caption)', color: 'var(--ink-3)', textTransform: 'uppercase', letterSpacing: 'var(--letter-spacing-wide)' }}>
|
||||||
Proposed · #{p.change.issue}
|
Proposed · #{p.change.issue}
|
||||||
</div>
|
</div>
|
||||||
<div style={{ font: '500 13px var(--font-mono)', color: 'var(--ink-1)' }}>{describeChange(p.plan)}</div>
|
<div style={{ font: '500 13px var(--font-mono)', color: 'var(--ink-1)' }}>{p.summary}</div>
|
||||||
<div style={{ display: 'flex', gap: 8 }}>
|
<div style={{ display: 'flex', gap: 8 }}>
|
||||||
<Button size="sm" onClick={() => approve(p)} disabled={offline}>
|
<Button size="sm" onClick={() => approve(p)} disabled={offline}>
|
||||||
Approve
|
Approve
|
||||||
|
|||||||
@@ -361,11 +361,14 @@ export interface CalibrationData {
|
|||||||
scatter: number[][]
|
scatter: number[][]
|
||||||
fit: number
|
fit: number
|
||||||
effect: { raw: string; banded: string; p50: string }
|
effect: { raw: string; banded: string; p50: string }
|
||||||
|
/** Closed+estimated issues that can't calibrate (same-day / 0-day closes). */
|
||||||
|
excludedSameDay: number
|
||||||
}
|
}
|
||||||
|
|
||||||
export const CALIBRATION: CalibrationData = {
|
export const CALIBRATION: CalibrationData = {
|
||||||
n: 27,
|
n: 27,
|
||||||
active: true,
|
active: true,
|
||||||
|
excludedSameDay: 0,
|
||||||
labels: [
|
labels: [
|
||||||
{ label: 'est/1d', n: 8, median: '1.1d', bias: 8 },
|
{ label: 'est/1d', n: 8, median: '1.1d', bias: 8 },
|
||||||
{ label: 'est/2d', n: 9, median: '2.4d', bias: 18 },
|
{ label: 'est/2d', n: 9, median: '2.4d', bias: 18 },
|
||||||
|
|||||||
4
apps/desktop/src/renderer/src/global.d.ts
vendored
4
apps/desktop/src/renderer/src/global.d.ts
vendored
@@ -17,7 +17,8 @@ import type {
|
|||||||
/** The result of a write through the bridge. */
|
/** The result of a write through the bridge. */
|
||||||
export type ApplyChangeResult =
|
export type ApplyChangeResult =
|
||||||
| { ok: false; reason: 'unconfigured' }
|
| { ok: false; reason: 'unconfigured' }
|
||||||
| { ok: true; plan: LabelPlan; issue: GiteaIssue }
|
// `plan` is present for label swaps (est/p); absent for field writes (assign, milestone).
|
||||||
|
| { ok: true; plan?: LabelPlan; issue: GiteaIssue }
|
||||||
|
|
||||||
/** The result of filing captured issues. */
|
/** The result of filing captured issues. */
|
||||||
export type CreateIssuesResult =
|
export type CreateIssuesResult =
|
||||||
@@ -85,6 +86,7 @@ export interface GiteaBridge {
|
|||||||
getIssue(index: number): Promise<GiteaIssue | null>
|
getIssue(index: number): Promise<GiteaIssue | null>
|
||||||
applyChange(change: IssueChange): Promise<ApplyChangeResult>
|
applyChange(change: IssueChange): Promise<ApplyChangeResult>
|
||||||
createIssues(issues: ProposedIssue[]): Promise<CreateIssuesResult>
|
createIssues(issues: ProposedIssue[]): Promise<CreateIssuesResult>
|
||||||
|
collaborators(): Promise<{ login: string; name: string }[]>
|
||||||
}
|
}
|
||||||
|
|
||||||
/** One agent turn's result. */
|
/** One agent turn's result. */
|
||||||
|
|||||||
@@ -1,6 +1,8 @@
|
|||||||
import {
|
import {
|
||||||
|
type CalibrationCoverage,
|
||||||
type CalibrationModel,
|
type CalibrationModel,
|
||||||
type CalibrationSample,
|
type CalibrationSample,
|
||||||
|
calibrationCoverage,
|
||||||
calibrationSamples,
|
calibrationSamples,
|
||||||
type CapacityMember,
|
type CapacityMember,
|
||||||
capacityPerWorkday,
|
capacityPerWorkday,
|
||||||
@@ -171,10 +173,11 @@ export function backlogCalibration(
|
|||||||
issues: GiteaIssue[],
|
issues: GiteaIssue[],
|
||||||
timelines: Timelines = {},
|
timelines: Timelines = {},
|
||||||
asOf: Date = new Date(),
|
asOf: Date = new Date(),
|
||||||
): { model: CalibrationModel; data: CalibrationData } {
|
): { model: CalibrationModel; data: CalibrationData; coverage: CalibrationCoverage } {
|
||||||
const samples = calibrationSamples(issues, timelines, asOf)
|
const samples = calibrationSamples(issues, timelines, asOf)
|
||||||
const model = fitCalibration(samples)
|
const model = fitCalibration(samples)
|
||||||
return { model, data: calibrationData(model, samples, issues) }
|
const coverage = calibrationCoverage(issues, timelines, asOf)
|
||||||
|
return { model, coverage, data: calibrationData(model, samples, issues, coverage.excludedSameDay) }
|
||||||
}
|
}
|
||||||
|
|
||||||
const pctFromMu = (mu: number) => Math.round((Math.exp(mu) - 1) * 100)
|
const pctFromMu = (mu: number) => Math.round((Math.exp(mu) - 1) * 100)
|
||||||
@@ -188,6 +191,7 @@ export function calibrationData(
|
|||||||
model: CalibrationModel,
|
model: CalibrationModel,
|
||||||
samples: CalibrationSample[],
|
samples: CalibrationSample[],
|
||||||
openIssues: GiteaIssue[],
|
openIssues: GiteaIssue[],
|
||||||
|
excludedSameDay = 0,
|
||||||
): CalibrationData {
|
): CalibrationData {
|
||||||
const labels = PRIOR_BUCKETS.map((b) => {
|
const labels = PRIOR_BUCKETS.map((b) => {
|
||||||
const inBucket = samples.filter((s) => s.bucket === b)
|
const inBucket = samples.filter((s) => s.bucket === b)
|
||||||
@@ -227,6 +231,7 @@ export function calibrationData(
|
|||||||
scatter: samples.map((s) => [s.estimateDays, s.actualWorkingDays]),
|
scatter: samples.map((s) => [s.estimateDays, s.actualWorkingDays]),
|
||||||
fit: Number(Math.exp(model.global.mu).toFixed(2)),
|
fit: Number(Math.exp(model.global.mu).toFixed(2)),
|
||||||
effect,
|
effect,
|
||||||
|
excludedSameDay,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -133,14 +133,13 @@ export function useChat(onApplyChange?: (change: IssueChange) => Promise<{ ok: b
|
|||||||
(p: ChangeProposal) => {
|
(p: ChangeProposal) => {
|
||||||
if (!onApplyChange) return
|
if (!onApplyChange) return
|
||||||
drop(p)
|
drop(p)
|
||||||
const label = p.plan.added[0] ?? p.plan.removed[0] ?? 'change'
|
|
||||||
void onApplyChange(p.change).then((res) => {
|
void onApplyChange(p.change).then((res) => {
|
||||||
setConvo((c) => [
|
setConvo((c) => [
|
||||||
...c,
|
...c,
|
||||||
{
|
{
|
||||||
from: 'agent',
|
from: 'agent',
|
||||||
text: res.ok
|
text: res.ok
|
||||||
? `Done — #${p.change.issue} is now ${label}. The plan's been re-run.`
|
? `Done — #${p.change.issue}: ${p.summary}. The plan's been re-run.`
|
||||||
: `That didn't take — #${p.change.issue} is unchanged.`,
|
: `That didn't take — #${p.change.issue} is unchanged.`,
|
||||||
},
|
},
|
||||||
])
|
])
|
||||||
|
|||||||
@@ -17,10 +17,11 @@ export const QUERY_PROJECT_TOOL: ToolDecl = {
|
|||||||
properties: {
|
properties: {
|
||||||
view: {
|
view: {
|
||||||
type: 'string',
|
type: 'string',
|
||||||
enum: ['focus', 'board', 'calibration', 'issue', 'search'],
|
enum: ['focus', 'board', 'calibration', 'issue', 'search', 'standup'],
|
||||||
description:
|
description:
|
||||||
'focus = Now/Next/Later; board = issues by lifecycle column; calibration = estimate-vs-actual; ' +
|
'focus = Now/Next/Later; board = issues by lifecycle column; calibration = estimate-vs-actual; ' +
|
||||||
'issue = one issue (needs filters.issueId); search = issues matching filters.query.',
|
'issue = one issue (needs filters.issueId); search = issues matching filters.query; ' +
|
||||||
|
"standup = today's plan + overnight drift + the stalest blocker.",
|
||||||
},
|
},
|
||||||
filters: {
|
filters: {
|
||||||
type: 'object',
|
type: 'object',
|
||||||
@@ -38,15 +39,19 @@ export const QUERY_PROJECT_TOOL: ToolDecl = {
|
|||||||
export const PROPOSE_CHANGE_TOOL: ToolDecl = {
|
export const PROPOSE_CHANGE_TOOL: ToolDecl = {
|
||||||
name: 'propose_change',
|
name: 'propose_change',
|
||||||
description:
|
description:
|
||||||
"Propose an estimate and/or priority change to an issue. This does NOT apply anything — it shows the " +
|
'Propose a change to an issue — estimate, priority, assignee, and/or milestone. This does NOT apply ' +
|
||||||
'human a diff to approve. Use it whenever the user asks to re-estimate or reprioritize. After calling it, ' +
|
'anything; it shows the human a diff to approve. Use it whenever the user asks to re-estimate, reprioritize, ' +
|
||||||
"tell the user you've *proposed* the change for approval — never say it is done.",
|
'assign someone (or unassign), or move an issue to a milestone. Pass a login for `assignee` (null to ' +
|
||||||
|
'unassign) and a milestone id for `milestone` (null to remove). After calling it, tell the user you have ' +
|
||||||
|
'*proposed* the change for approval — never say it is done.',
|
||||||
parameters: {
|
parameters: {
|
||||||
type: 'object',
|
type: 'object',
|
||||||
properties: {
|
properties: {
|
||||||
issue: { type: 'number', description: 'the issue number to change' },
|
issue: { type: 'number', description: 'the issue number to change' },
|
||||||
estimate: { type: 'string', enum: ['est/1d', 'est/2d', 'est/3d', 'est/5d', 'est/8d'] },
|
estimate: { type: 'string', enum: ['est/1d', 'est/2d', 'est/3d', 'est/5d', 'est/8d'] },
|
||||||
priority: { type: 'string', enum: ['p/1', 'p/2', 'p/3', 'p/4'] },
|
priority: { type: 'string', enum: ['p/1', 'p/2', 'p/3', 'p/4'] },
|
||||||
|
assignee: { type: 'string', description: 'gitea login to assign, or null to unassign' },
|
||||||
|
milestone: { type: 'number', description: 'milestone id to set, or null to remove from its milestone' },
|
||||||
},
|
},
|
||||||
required: ['issue'],
|
required: ['issue'],
|
||||||
},
|
},
|
||||||
@@ -84,7 +89,7 @@ export const REGINALD_SYSTEM = [
|
|||||||
'You are Reginald, the calm, dry project manager inside CommiTea — a tool that runs projects on Gitea.',
|
'You are Reginald, the calm, dry project manager inside CommiTea — a tool that runs projects on Gitea.',
|
||||||
'Call query_project to ground every answer in the real project; never invent issues, numbers, or dates.',
|
'Call query_project to ground every answer in the real project; never invent issues, numbers, or dates.',
|
||||||
'The scheduler and forecasts are deterministic code — report their output, do not recompute it.',
|
'The scheduler and forecasts are deterministic code — report their output, do not recompute it.',
|
||||||
'To change an estimate or priority, call propose_change — it shows the human a diff to approve.',
|
'To change an estimate, priority, assignee, or milestone, call propose_change — it shows the human a diff to approve.',
|
||||||
'When the PM states standing intent ("pilots first", "freeze scope"), call record_directive to log it.',
|
'When the PM states standing intent ("pilots first", "freeze scope"), call record_directive to log it.',
|
||||||
'Never claim a change is applied; you propose, the human approves. Forecasts are ranges, never single dates.',
|
'Never claim a change is applied; you propose, the human approves. Forecasts are ranges, never single dates.',
|
||||||
'Refer to issues as #<number>. Be brief and plain — a sentence or two. No preamble, no bullet dumps.',
|
'Refer to issues as #<number>. Be brief and plain — a sentence or two. No preamble, no bullet dumps.',
|
||||||
|
|||||||
74
packages/core/src/agent/query-project.test.ts
Normal file
74
packages/core/src/agent/query-project.test.ts
Normal file
@@ -0,0 +1,74 @@
|
|||||||
|
import { describe, expect, it } from 'vitest'
|
||||||
|
|
||||||
|
import { extractLabelFacts } from '../labels/label-schema.js'
|
||||||
|
import type { LifecycleEvent } from '../lifecycle/lifecycle-v0.js'
|
||||||
|
import type { GiteaIssue } from '../gitea/types.js'
|
||||||
|
import { buildProjectView, type ProjectSnapshot } from './query-project.js'
|
||||||
|
|
||||||
|
const asOf = new Date('2026-02-12T00:00:00Z')
|
||||||
|
|
||||||
|
function issue(over: Partial<GiteaIssue>): GiteaIssue {
|
||||||
|
const labels = over.labels ?? ['est/2d']
|
||||||
|
return {
|
||||||
|
number: 1,
|
||||||
|
title: '#1',
|
||||||
|
body: '',
|
||||||
|
state: 'open',
|
||||||
|
labels,
|
||||||
|
facts: extractLabelFacts(labels),
|
||||||
|
milestone: null,
|
||||||
|
assignee: null,
|
||||||
|
assignees: [],
|
||||||
|
createdAt: '2026-02-02T09:00:00Z',
|
||||||
|
updatedAt: '2026-02-02T09:00:00Z',
|
||||||
|
closedAt: null,
|
||||||
|
url: '',
|
||||||
|
...over,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('buildProjectView: standup (#28)', () => {
|
||||||
|
it('surfaces schedule drift + a stale blocker, with a per-person plan', () => {
|
||||||
|
// #7 started work 6 working days ago (steeping) and blocks #8; est is 2d → past estimate.
|
||||||
|
const steeping = issue({ number: 7, labels: ['est/2d', 'p/1'], assignee: 'christian' })
|
||||||
|
const blocked = issue({ number: 8, labels: ['est/3d', 'p/2'], assignee: 'stephen' })
|
||||||
|
const timelines: Record<number, LifecycleEvent[]> = {
|
||||||
|
7: [{ type: 'commit', at: '2026-02-04T09:00:00Z' }],
|
||||||
|
}
|
||||||
|
const snap: ProjectSnapshot = { issues: [steeping, blocked], timelines, deps: [{ issue: 8, dependsOn: 7 }] }
|
||||||
|
|
||||||
|
const v = buildProjectView('standup', undefined, snap, asOf) as {
|
||||||
|
plan: { who: string; issue: number; why: string }[]
|
||||||
|
drift: { issue: number; note: string }[]
|
||||||
|
nag: { issue: number; steepingDays: number; blocks: number[] } | null
|
||||||
|
}
|
||||||
|
|
||||||
|
// a stale blocker is nagged, and it's the steeping one that blocks another
|
||||||
|
expect(v.nag).not.toBeNull()
|
||||||
|
expect(v.nag!.issue).toBe(7)
|
||||||
|
expect(v.nag!.steepingDays).toBeGreaterThan(0)
|
||||||
|
expect(v.nag!.blocks).toContain(8)
|
||||||
|
|
||||||
|
// drift caught the past-estimate steep
|
||||||
|
expect(v.drift.some((d) => d.issue === 7)).toBe(true)
|
||||||
|
|
||||||
|
// plan gives an earliest pick per person (both assignees represented)
|
||||||
|
expect(v.plan.map((p) => p.who)).toEqual(expect.arrayContaining(['christian', 'stephen']))
|
||||||
|
// #7 leads its person's plan on the critical path
|
||||||
|
expect(v.plan.find((p) => p.issue === 7)?.why).toContain('critical')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('is calm when nothing is steeping (no nag, empty drift)', () => {
|
||||||
|
const snap: ProjectSnapshot = {
|
||||||
|
issues: [issue({ number: 1, labels: ['est/2d'] })],
|
||||||
|
timelines: {},
|
||||||
|
deps: [],
|
||||||
|
}
|
||||||
|
const v = buildProjectView('standup', undefined, snap, asOf) as {
|
||||||
|
drift: unknown[]
|
||||||
|
nag: unknown | null
|
||||||
|
}
|
||||||
|
expect(v.nag).toBeNull()
|
||||||
|
expect(v.drift).toEqual([])
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -4,9 +4,9 @@
|
|||||||
* deterministic code (scheduler, lifecycle inference, calibration); the model
|
* deterministic code (scheduler, lifecycle inference, calibration); the model
|
||||||
* only requests a shape and narrates it — it never computes (decisions.md).
|
* only requests a shape and narrates it — it never computes (decisions.md).
|
||||||
*
|
*
|
||||||
* v0 serves focus / board / calibration / issue. The remaining views
|
* Serves focus / board / calibration / issue / search / standup. The remaining
|
||||||
* (milestone / runway / standup / search) return a `notImplemented` marker so
|
* views (milestone / runway) return a `notImplemented` marker so the model
|
||||||
* the model degrades honestly instead of inventing data.
|
* degrades honestly instead of inventing data.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { fitCalibration, calibrationSamples } from '../calibration/calibration-v0.js'
|
import { fitCalibration, calibrationSamples } from '../calibration/calibration-v0.js'
|
||||||
@@ -121,6 +121,62 @@ function searchView(snap: ProjectSnapshot, filters: QueryFilters) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Standup — the morning ritual as a compact, model-narratable payload: today's
|
||||||
|
* plan (the scheduler's earliest pick per person), overnight drift (real
|
||||||
|
* anomalies — issues sitting in review or steeping past their estimate), and the
|
||||||
|
* single stalest blocker to nag about. All from deterministic code; the model
|
||||||
|
* narrates it. Satisfies #28's "surfaces schedule drift + at least one stale blocker".
|
||||||
|
*/
|
||||||
|
function standupView(snap: ProjectSnapshot, asOf: Date) {
|
||||||
|
const plan = schedule(toSchedulable(snap.issues), snap.deps)
|
||||||
|
const open = snap.issues.filter((i) => i.state === 'open')
|
||||||
|
const infOf = (i: GiteaIssue) => inferLifecycle(i, snap.timelines[i.number] ?? [], asOf)
|
||||||
|
|
||||||
|
// plan: the earliest scheduled pick per assignee (dependency + priority order)
|
||||||
|
const seen = new Set<string>()
|
||||||
|
const planPicks: { who: string; issue: number; title: string; why: string }[] = []
|
||||||
|
for (const item of plan.items) {
|
||||||
|
const who = open.find((i) => i.number === item.number)?.assignee ?? 'unassigned'
|
||||||
|
if (seen.has(who)) continue
|
||||||
|
seen.add(who)
|
||||||
|
planPicks.push({
|
||||||
|
who,
|
||||||
|
issue: item.number,
|
||||||
|
title: item.title,
|
||||||
|
why: item.critical
|
||||||
|
? 'on the critical path'
|
||||||
|
: item.blocks.length
|
||||||
|
? `blocks ${item.blocks.map((b) => `#${b}`).join(', ')}`
|
||||||
|
: 'next by dependency + priority',
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// drift: real overnight anomalies (review-sitting, steeping past estimate)
|
||||||
|
const drift: { issue: number; note: string }[] = []
|
||||||
|
for (const i of open) {
|
||||||
|
const inf = infOf(i)
|
||||||
|
if (inf.column === 'review') drift.push({ issue: i.number, note: `#${i.number} is sitting in review` })
|
||||||
|
else if (inf.steepingDays != null && inf.steepingDays > (i.facts.estimateDays ?? 2))
|
||||||
|
drift.push({
|
||||||
|
issue: i.number,
|
||||||
|
note: `#${i.number} has steeped ${inf.steepingDays}d past its ${i.facts.estimateDays ?? 2}d estimate`,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// nag: the single longest-steeping open issue + what it blocks
|
||||||
|
let nag: { issue: number; steepingDays: number; blocks: number[] } | null = null
|
||||||
|
for (const i of open) {
|
||||||
|
const inf = infOf(i)
|
||||||
|
if (inf.steepingDays == null) continue
|
||||||
|
if (!nag || inf.steepingDays > nag.steepingDays) {
|
||||||
|
nag = { issue: i.number, steepingDays: inf.steepingDays, blocks: plan.items.find((it) => it.number === i.number)?.blocks ?? [] }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return { date: asOf.toISOString().slice(0, 10), plan: planPicks.slice(0, 5), drift: drift.slice(0, 5), nag }
|
||||||
|
}
|
||||||
|
|
||||||
/** Build the compact payload for one view. Unknown/unbuilt views return a marker. */
|
/** Build the compact payload for one view. Unknown/unbuilt views return a marker. */
|
||||||
export function buildProjectView(
|
export function buildProjectView(
|
||||||
view: ProjectView,
|
view: ProjectView,
|
||||||
@@ -140,6 +196,8 @@ export function buildProjectView(
|
|||||||
return issueView(snap, f, asOf)
|
return issueView(snap, f, asOf)
|
||||||
case 'search':
|
case 'search':
|
||||||
return searchView(snap, f)
|
return searchView(snap, f)
|
||||||
|
case 'standup':
|
||||||
|
return standupView(snap, asOf)
|
||||||
default:
|
default:
|
||||||
return { notImplemented: view }
|
return { notImplemented: view }
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import type { LifecycleEvent } from '../lifecycle/lifecycle-v0.js'
|
|||||||
import type { GiteaIssue } from '../gitea/types.js'
|
import type { GiteaIssue } from '../gitea/types.js'
|
||||||
import {
|
import {
|
||||||
CALIBRATION_BUCKET_FLOOR,
|
CALIBRATION_BUCKET_FLOOR,
|
||||||
|
calibrationCoverage,
|
||||||
calibrationSamples,
|
calibrationSamples,
|
||||||
type CalibrationSample,
|
type CalibrationSample,
|
||||||
COLD_START_THRESHOLD,
|
COLD_START_THRESHOLD,
|
||||||
@@ -118,4 +119,26 @@ describe('calibrationSamples', () => {
|
|||||||
const noEst = issue({ number: 9, labels: [] })
|
const noEst = issue({ number: 9, labels: [] })
|
||||||
expect(calibrationSamples([open, noEst], { ...events(8), ...events(9) }, asOf)).toEqual([])
|
expect(calibrationSamples([open, noEst], { ...events(8), ...events(9) }, asOf)).toEqual([])
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('coverage counts same-day closes as excluded candidates, not as "more closes needed"', () => {
|
||||||
|
// usable: commit Wed 01-07 → close Mon 01-12 = 3 working days
|
||||||
|
const usable = issue({ number: 7, labels: ['est/2d'] })
|
||||||
|
// same-day close: commit and close on the same day = 0 working days → excluded
|
||||||
|
const sameDay = issue({ number: 10, labels: ['est/2d'], createdAt: '2026-01-12T08:00:00Z' })
|
||||||
|
const sameDayEvents = {
|
||||||
|
10: [
|
||||||
|
{ type: 'commit', at: '2026-01-12T09:00:00Z' } as LifecycleEvent,
|
||||||
|
{ type: 'close', at: '2026-01-12T17:00:00Z' } as LifecycleEvent,
|
||||||
|
],
|
||||||
|
}
|
||||||
|
const open = issue({ number: 8, state: 'open', labels: ['est/2d'], closedAt: null })
|
||||||
|
const noEst = issue({ number: 9, labels: [] })
|
||||||
|
|
||||||
|
const cov = calibrationCoverage([usable, sameDay, open, noEst], { ...events(7), ...sameDayEvents }, asOf)
|
||||||
|
expect(cov.candidates).toBe(2) // closed + estimated only (usable + sameDay)
|
||||||
|
expect(cov.usable).toBe(1)
|
||||||
|
expect(cov.excludedSameDay).toBe(1)
|
||||||
|
// the honest denominator: usable matches the model's n
|
||||||
|
expect(cov.usable).toBe(calibrationSamples([usable, sameDay, open, noEst], { ...events(7), ...sameDayEvents }, asOf).length)
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -125,3 +125,40 @@ export function calibrationSamples(
|
|||||||
}
|
}
|
||||||
return out
|
return out
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** How the closed+estimated backlog splits into usable samples vs. what can't calibrate. */
|
||||||
|
export interface CalibrationCoverage {
|
||||||
|
/** Closed issues carrying an estimate — the calibration candidates. */
|
||||||
|
candidates: number
|
||||||
|
/** Candidates that yielded a usable actual (> 0 working days) → become samples. */
|
||||||
|
usable: number
|
||||||
|
/**
|
||||||
|
* Candidates excluded because the issue closed with 0 working days (same-day
|
||||||
|
* close) or no resolvable actual — real closes that structurally can't
|
||||||
|
* calibrate. Counting them keeps `usable/threshold` honest: it's not "N more
|
||||||
|
* closes away" if some of your closes will never count.
|
||||||
|
*/
|
||||||
|
excludedSameDay: number
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Coverage of the calibration candidates — how many closed+estimated issues are
|
||||||
|
* usable vs. silently unusable (same-day / 0-day closes). {@link calibrationSamples}
|
||||||
|
* drops the latter; this counts them so the UI can say *why* the sample is thin.
|
||||||
|
*/
|
||||||
|
export function calibrationCoverage(
|
||||||
|
issues: GiteaIssue[],
|
||||||
|
timelines: Record<number, LifecycleEvent[]>,
|
||||||
|
asOf: Date,
|
||||||
|
): CalibrationCoverage {
|
||||||
|
let candidates = 0
|
||||||
|
let usable = 0
|
||||||
|
for (const issue of issues) {
|
||||||
|
if (issue.state !== 'closed') continue
|
||||||
|
if (issue.facts.estimateDays == null) continue
|
||||||
|
candidates++
|
||||||
|
const inf = inferLifecycle(issue, timelines[issue.number] ?? [], asOf)
|
||||||
|
if (inf.actualWorkingDays != null && inf.actualWorkingDays > 0) usable++
|
||||||
|
}
|
||||||
|
return { candidates, usable, excludedSameDay: candidates - usable }
|
||||||
|
}
|
||||||
|
|||||||
@@ -1,6 +1,13 @@
|
|||||||
import { describe, expect, it } from 'vitest'
|
import { describe, expect, it } from 'vitest'
|
||||||
|
|
||||||
import { describeChange, type IssueChange, planIssueChange, proposalsFor } from './apply-changes-v0.js'
|
import {
|
||||||
|
describeChange,
|
||||||
|
isLabelChange,
|
||||||
|
type IssueChange,
|
||||||
|
planIssueChange,
|
||||||
|
proposalsFor,
|
||||||
|
summarizeChange,
|
||||||
|
} from './apply-changes-v0.js'
|
||||||
|
|
||||||
describe('planIssueChange', () => {
|
describe('planIssueChange', () => {
|
||||||
it('swaps the estimate label, keeping non-axis labels', () => {
|
it('swaps the estimate label, keeping non-axis labels', () => {
|
||||||
@@ -58,11 +65,31 @@ describe('proposalsFor', () => {
|
|||||||
const props = proposalsFor({ issue: 2, estimate: 'est/5d', priority: 'p/1' }, ['est/2d', 'p/3'], 'ChangeSource')
|
const props = proposalsFor({ issue: 2, estimate: 'est/5d', priority: 'p/1' }, ['est/2d', 'p/3'], 'ChangeSource')
|
||||||
expect(props).toHaveLength(2)
|
expect(props).toHaveLength(2)
|
||||||
expect(props[0].change).toEqual({ kind: 'reestimate', issue: 2, estimate: 'est/5d' })
|
expect(props[0].change).toEqual({ kind: 'reestimate', issue: 2, estimate: 'est/5d' })
|
||||||
expect(describeChange(props[0].plan)).toBe('est/2d → est/5d')
|
expect(props[0].summary).toBe('est/2d → est/5d')
|
||||||
expect(props[1].change).toEqual({ kind: 'reprioritize', issue: 2, priority: 'p/1' })
|
expect(props[1].change).toEqual({ kind: 'reprioritize', issue: 2, priority: 'p/1' })
|
||||||
expect(props[0].issueTitle).toBe('ChangeSource')
|
expect(props[0].issueTitle).toBe('ChangeSource')
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('proposes an assignment only when it differs from the current assignee', () => {
|
||||||
|
const change = proposalsFor({ issue: 2, assignee: 'christian' }, [], undefined, { currentAssignee: null })
|
||||||
|
expect(change).toHaveLength(1)
|
||||||
|
expect(change[0].change).toEqual({ kind: 'assign', issue: 2, assignee: 'christian' })
|
||||||
|
expect(change[0].summary).toBe('assign → @christian')
|
||||||
|
expect(change[0].plan).toBeUndefined()
|
||||||
|
// already assigned → no proposal
|
||||||
|
expect(proposalsFor({ issue: 2, assignee: 'christian' }, [], undefined, { currentAssignee: 'christian' })).toEqual([])
|
||||||
|
})
|
||||||
|
|
||||||
|
it('proposes a milestone move, labeled from the milestones list, skipping a no-op', () => {
|
||||||
|
const ctx = { currentMilestoneId: 1, milestones: [{ id: 3, title: 'P5 — Dogfood' }] }
|
||||||
|
const props = proposalsFor({ issue: 2, milestone: 3 }, [], undefined, ctx)
|
||||||
|
expect(props).toHaveLength(1)
|
||||||
|
expect(props[0].change).toEqual({ kind: 'remilestone', issue: 2, milestone: 3, milestoneTitle: 'P5 — Dogfood' })
|
||||||
|
expect(props[0].summary).toBe('milestone → P5 — Dogfood')
|
||||||
|
// same milestone → no proposal
|
||||||
|
expect(proposalsFor({ issue: 2, milestone: 1 }, [], undefined, ctx)).toEqual([])
|
||||||
|
})
|
||||||
|
|
||||||
it('drops a noop axis (already at the requested value)', () => {
|
it('drops a noop axis (already at the requested value)', () => {
|
||||||
const props = proposalsFor({ issue: 2, estimate: 'est/2d', priority: 'p/1' }, ['est/2d', 'p/3'])
|
const props = proposalsFor({ issue: 2, estimate: 'est/2d', priority: 'p/1' }, ['est/2d', 'p/3'])
|
||||||
expect(props.map((p) => p.change.kind)).toEqual(['reprioritize']) // estimate unchanged
|
expect(props.map((p) => p.change.kind)).toEqual(['reprioritize']) // estimate unchanged
|
||||||
@@ -77,3 +104,31 @@ describe('proposalsFor', () => {
|
|||||||
expect(proposalsFor({ issue: 2 }, ['est/2d'])).toEqual([])
|
expect(proposalsFor({ issue: 2 }, ['est/2d'])).toEqual([])
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
describe('unified change model (assign + milestone)', () => {
|
||||||
|
it('isLabelChange narrows label kinds only', () => {
|
||||||
|
expect(isLabelChange({ kind: 'reestimate', issue: 1, estimate: 'est/2d' })).toBe(true)
|
||||||
|
expect(isLabelChange({ kind: 'reprioritize', issue: 1, priority: 'p/1' })).toBe(true)
|
||||||
|
expect(isLabelChange({ kind: 'assign', issue: 1, assignee: 'christian' })).toBe(false)
|
||||||
|
expect(isLabelChange({ kind: 'remilestone', issue: 1, milestone: 3 })).toBe(false)
|
||||||
|
})
|
||||||
|
|
||||||
|
it('summarizeChange describes an assignment and an unassignment', () => {
|
||||||
|
expect(summarizeChange({ kind: 'assign', issue: 1, assignee: 'christian' })).toBe('assign → @christian')
|
||||||
|
expect(summarizeChange({ kind: 'assign', issue: 1, assignee: null })).toBe('unassign')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('summarizeChange describes a milestone set (by title) and removal', () => {
|
||||||
|
expect(summarizeChange({ kind: 'remilestone', issue: 1, milestone: 3, milestoneTitle: 'P5 — Dogfood' })).toBe(
|
||||||
|
'milestone → P5 — Dogfood',
|
||||||
|
)
|
||||||
|
expect(summarizeChange({ kind: 'remilestone', issue: 1, milestone: 3 })).toBe('milestone → #3')
|
||||||
|
expect(summarizeChange({ kind: 'remilestone', issue: 1, milestone: null })).toBe('remove from milestone')
|
||||||
|
})
|
||||||
|
|
||||||
|
it('summarizeChange delegates label kinds to describeChange (needs current labels)', () => {
|
||||||
|
const change: IssueChange = { kind: 'reestimate', issue: 1, estimate: 'est/5d' }
|
||||||
|
expect(summarizeChange(change, ['est/2d'])).toBe('est/2d → est/5d')
|
||||||
|
expect(summarizeChange(change, ['est/5d'])).toBe('no change')
|
||||||
|
})
|
||||||
|
})
|
||||||
|
|||||||
@@ -17,6 +17,15 @@ import {
|
|||||||
export type IssueChange =
|
export type IssueChange =
|
||||||
| { kind: 'reestimate'; issue: number; estimate: EstimateLabel | null }
|
| { kind: 'reestimate'; issue: number; estimate: EstimateLabel | null }
|
||||||
| { kind: 'reprioritize'; issue: number; priority: PriorityLabel | null }
|
| { kind: 'reprioritize'; issue: number; priority: PriorityLabel | null }
|
||||||
|
| { kind: 'assign'; issue: number; assignee: string | null }
|
||||||
|
| { kind: 'remilestone'; issue: number; milestone: number | null; milestoneTitle?: string | null }
|
||||||
|
|
||||||
|
/** The label axes are the only kinds planned as a label swap; the rest are field writes. */
|
||||||
|
export function isLabelChange(
|
||||||
|
change: IssueChange,
|
||||||
|
): change is Extract<IssueChange, { kind: 'reestimate' | 'reprioritize' }> {
|
||||||
|
return change.kind === 'reestimate' || change.kind === 'reprioritize'
|
||||||
|
}
|
||||||
|
|
||||||
export interface LabelPlan {
|
export interface LabelPlan {
|
||||||
/** The full resulting label-name set (order: kept labels, then the new axis label). */
|
/** The full resulting label-name set (order: kept labels, then the new axis label). */
|
||||||
@@ -29,7 +38,10 @@ export interface LabelPlan {
|
|||||||
noop: boolean
|
noop: boolean
|
||||||
}
|
}
|
||||||
|
|
||||||
function axisFor(change: IssueChange): { labels: readonly string[]; target: string | null } {
|
/** A change that resolves to a label swap (the only kind `planIssueChange` accepts). */
|
||||||
|
export type LabelChange = Extract<IssueChange, { kind: 'reestimate' | 'reprioritize' }>
|
||||||
|
|
||||||
|
function axisFor(change: LabelChange): { labels: readonly string[]; target: string | null } {
|
||||||
return change.kind === 'reestimate'
|
return change.kind === 'reestimate'
|
||||||
? { labels: ESTIMATE_LABELS, target: change.estimate }
|
? { labels: ESTIMATE_LABELS, target: change.estimate }
|
||||||
: { labels: PRIORITY_LABELS, target: change.priority }
|
: { labels: PRIORITY_LABELS, target: change.priority }
|
||||||
@@ -40,7 +52,7 @@ function axisFor(change: IssueChange): { labels: readonly string[]; target: stri
|
|||||||
* change's axis except the target, adds the target if absent. Setting the axis
|
* change's axis except the target, adds the target if absent. Setting the axis
|
||||||
* to null clears it. Cleans up a duplicated axis (two `est/*`) as a side effect.
|
* to null clears it. Cleans up a duplicated axis (two `est/*`) as a side effect.
|
||||||
*/
|
*/
|
||||||
export function planIssueChange(current: string[], change: IssueChange): LabelPlan {
|
export function planIssueChange(current: string[], change: LabelChange): LabelPlan {
|
||||||
const { labels: axis, target } = axisFor(change)
|
const { labels: axis, target } = axisFor(change)
|
||||||
const onAxis = current.filter((l) => axis.includes(l))
|
const onAxis = current.filter((l) => axis.includes(l))
|
||||||
const removed = onAxis.filter((l) => l !== target)
|
const removed = onAxis.filter((l) => l !== target)
|
||||||
@@ -58,18 +70,52 @@ export function describeChange(plan: LabelPlan): string {
|
|||||||
return `${from} → ${to}`
|
return `${from} → ${to}`
|
||||||
}
|
}
|
||||||
|
|
||||||
/** A change the agent proposes: the concrete op + its diff, ready for approve-then-apply. */
|
/**
|
||||||
|
* One human-readable confirm line for ANY change kind — the unified describe for
|
||||||
|
* the propose-approve UI. Label kinds delegate to {@link describeChange} (so they
|
||||||
|
* need the issue's current labels); assign/milestone describe the field write
|
||||||
|
* directly. Pure; no network.
|
||||||
|
*/
|
||||||
|
export function summarizeChange(change: IssueChange, currentLabels: string[] = []): string {
|
||||||
|
switch (change.kind) {
|
||||||
|
case 'reestimate':
|
||||||
|
case 'reprioritize':
|
||||||
|
return describeChange(planIssueChange(currentLabels, change))
|
||||||
|
case 'assign':
|
||||||
|
return change.assignee ? `assign → @${change.assignee}` : 'unassign'
|
||||||
|
case 'remilestone':
|
||||||
|
return change.milestone == null
|
||||||
|
? 'remove from milestone'
|
||||||
|
: `milestone → ${change.milestoneTitle ?? `#${change.milestone}`}`
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** A change the agent proposes: the concrete op + its human diff, ready for approve-then-apply. */
|
||||||
export interface ChangeProposal {
|
export interface ChangeProposal {
|
||||||
change: IssueChange
|
change: IssueChange
|
||||||
plan: LabelPlan
|
/** One-line diff for the approve UI — always present ({@link summarizeChange}). */
|
||||||
|
summary: string
|
||||||
|
/** The label plan, for label kinds only (absent for assign/milestone). */
|
||||||
|
plan?: LabelPlan
|
||||||
issueTitle?: string
|
issueTitle?: string
|
||||||
}
|
}
|
||||||
|
|
||||||
/** What the `propose_change` tool accepts — a target issue and the axes to set. */
|
/** What the `propose_change` tool accepts — a target issue and the fields to set. */
|
||||||
export interface ProposeChangeArgs {
|
export interface ProposeChangeArgs {
|
||||||
issue: number
|
issue: number
|
||||||
estimate?: EstimateLabel
|
estimate?: EstimateLabel
|
||||||
priority?: PriorityLabel
|
priority?: PriorityLabel
|
||||||
|
/** Login to assign, or null to unassign. Omit to leave assignee untouched. */
|
||||||
|
assignee?: string | null
|
||||||
|
/** Milestone id to set, or null to clear. Omit to leave the milestone untouched. */
|
||||||
|
milestone?: number | null
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Current state + lookups a proposal needs to skip noops and label the milestone. */
|
||||||
|
export interface ProposalContext {
|
||||||
|
currentAssignee?: string | null
|
||||||
|
currentMilestoneId?: number | null
|
||||||
|
milestones?: { id: number; title: string }[]
|
||||||
}
|
}
|
||||||
|
|
||||||
function isEstimate(v: unknown): v is EstimateLabel {
|
function isEstimate(v: unknown): v is EstimateLabel {
|
||||||
@@ -80,25 +126,33 @@ function isPriority(v: unknown): v is PriorityLabel {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Build the concrete, non-noop proposals for a `propose_change` request against
|
* Build the concrete, non-noop proposals for a `propose_change` request. Label
|
||||||
* an issue's current labels. Invalid or unchanged axes are dropped — the agent
|
* axes (est/*, p/*) are validated and never invented; assign/milestone are
|
||||||
* proposes only real changes, and never a label outside the est/* · p/* axes.
|
* emitted only when they differ from the issue's current value (via `ctx`). Each
|
||||||
|
* proposal carries a human `summary`; label kinds also carry the label plan.
|
||||||
*/
|
*/
|
||||||
export function proposalsFor(
|
export function proposalsFor(
|
||||||
args: ProposeChangeArgs,
|
args: ProposeChangeArgs,
|
||||||
currentLabels: string[],
|
currentLabels: string[],
|
||||||
issueTitle?: string,
|
issueTitle?: string,
|
||||||
|
ctx: ProposalContext = {},
|
||||||
): ChangeProposal[] {
|
): ChangeProposal[] {
|
||||||
const out: ChangeProposal[] = []
|
const out: ChangeProposal[] = []
|
||||||
if (isEstimate(args.estimate)) {
|
const pushLabel = (change: LabelChange) => {
|
||||||
const change: IssueChange = { kind: 'reestimate', issue: args.issue, estimate: args.estimate }
|
|
||||||
const plan = planIssueChange(currentLabels, change)
|
const plan = planIssueChange(currentLabels, change)
|
||||||
if (!plan.noop) out.push({ change, plan, issueTitle })
|
if (!plan.noop) out.push({ change, plan, summary: describeChange(plan), issueTitle })
|
||||||
}
|
}
|
||||||
if (isPriority(args.priority)) {
|
if (isEstimate(args.estimate)) pushLabel({ kind: 'reestimate', issue: args.issue, estimate: args.estimate })
|
||||||
const change: IssueChange = { kind: 'reprioritize', issue: args.issue, priority: args.priority }
|
if (isPriority(args.priority)) pushLabel({ kind: 'reprioritize', issue: args.issue, priority: args.priority })
|
||||||
const plan = planIssueChange(currentLabels, change)
|
|
||||||
if (!plan.noop) out.push({ change, plan, issueTitle })
|
if (args.assignee !== undefined && args.assignee !== (ctx.currentAssignee ?? null)) {
|
||||||
|
const change: IssueChange = { kind: 'assign', issue: args.issue, assignee: args.assignee }
|
||||||
|
out.push({ change, summary: summarizeChange(change), issueTitle })
|
||||||
|
}
|
||||||
|
if (args.milestone !== undefined && args.milestone !== (ctx.currentMilestoneId ?? null)) {
|
||||||
|
const milestoneTitle = ctx.milestones?.find((m) => m.id === args.milestone)?.title ?? null
|
||||||
|
const change: IssueChange = { kind: 'remilestone', issue: args.issue, milestone: args.milestone, milestoneTitle }
|
||||||
|
out.push({ change, summary: summarizeChange(change), issueTitle })
|
||||||
}
|
}
|
||||||
return out
|
return out
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -146,6 +146,22 @@ describe('createGiteaClient.getIssue', () => {
|
|||||||
])
|
])
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('listCollaborators maps login+name and prepends the owner when absent', async () => {
|
||||||
|
const { fetch } = stubFetch([{ login: 'stephen', full_name: 'Stephen M.' }])
|
||||||
|
const people = await createGiteaClient(CONFIG, fetch).listCollaborators()
|
||||||
|
// owner (christian) prepended since /collaborators omits them; collaborator name preserved
|
||||||
|
expect(people).toEqual([
|
||||||
|
{ login: 'christian', name: 'christian' },
|
||||||
|
{ login: 'stephen', name: 'Stephen M.' },
|
||||||
|
])
|
||||||
|
})
|
||||||
|
|
||||||
|
it('listCollaborators does not double-add the owner when already listed', async () => {
|
||||||
|
const { fetch } = stubFetch([{ login: 'christian', full_name: 'Christian L.' }])
|
||||||
|
const people = await createGiteaClient(CONFIG, fetch).listCollaborators()
|
||||||
|
expect(people).toEqual([{ login: 'christian', name: 'Christian L.' }])
|
||||||
|
})
|
||||||
|
|
||||||
it('getFile returns null on 404 and content+sha on hit', async () => {
|
it('getFile returns null on 404 and content+sha on hit', async () => {
|
||||||
const miss = stubFetch('nope', 404)
|
const miss = stubFetch('nope', 404)
|
||||||
expect(await createGiteaClient(CONFIG, miss.fetch).getFile('directives/log.jsonl')).toBeNull()
|
expect(await createGiteaClient(CONFIG, miss.fetch).getFile('directives/log.jsonl')).toBeNull()
|
||||||
|
|||||||
@@ -101,8 +101,14 @@ export interface GiteaClient {
|
|||||||
getIssueTimeline(index: number): Promise<LifecycleEvent[]>
|
getIssueTimeline(index: number): Promise<LifecycleEvent[]>
|
||||||
/** Every label defined on the repo (id + name), for name→id resolution. */
|
/** Every label defined on the repo (id + name), for name→id resolution. */
|
||||||
listLabels(): Promise<GiteaLabel[]>
|
listLabels(): Promise<GiteaLabel[]>
|
||||||
|
/** Repo collaborators (login + display name) — the assignable people. */
|
||||||
|
listCollaborators(): Promise<{ login: string; name: string }[]>
|
||||||
/** Replace an issue's entire label set with the given label ids. Write. */
|
/** Replace an issue's entire label set with the given label ids. Write. */
|
||||||
setIssueLabels(index: number, labelIds: number[]): Promise<void>
|
setIssueLabels(index: number, labelIds: number[]): Promise<void>
|
||||||
|
/** Replace an issue's assignees (empty array unassigns); returns the updated issue. Write. */
|
||||||
|
setIssueAssignees(index: number, logins: string[]): Promise<GiteaIssue>
|
||||||
|
/** Set (or clear, with null) an issue's milestone by id; returns the updated issue. Write. */
|
||||||
|
setIssueMilestone(index: number, milestoneId: number | null): Promise<GiteaIssue>
|
||||||
/** Open a new issue with a title, optional body, and label ids. Write. */
|
/** Open a new issue with a title, optional body, and label ids. Write. */
|
||||||
createIssue(input: { title: string; body?: string; labelIds?: number[] }): Promise<GiteaIssue>
|
createIssue(input: { title: string; body?: string; labelIds?: number[] }): Promise<GiteaIssue>
|
||||||
/** Read a repo file's base64 content + blob sha; null if it (or the repo) is absent. */
|
/** Read a repo file's base64 content + blob sha; null if it (or the repo) is absent. */
|
||||||
@@ -229,6 +235,33 @@ export function createGiteaClient(config: GiteaConfig, fetchImpl: FetchLike): Gi
|
|||||||
await request(`/issues/${index}/labels`, { method: 'PUT', body: { labels: labelIds } })
|
await request(`/issues/${index}/labels`, { method: 'PUT', body: { labels: labelIds } })
|
||||||
},
|
},
|
||||||
|
|
||||||
|
async listCollaborators() {
|
||||||
|
const raw = await requestAll<{ login: string; full_name?: string }>(
|
||||||
|
(page) => `/collaborators?page=${page}&limit=${PAGE_LIMIT}`,
|
||||||
|
)
|
||||||
|
const collabs = raw.map((u) => ({ login: u.login, name: u.full_name || u.login }))
|
||||||
|
// The owner is assignable but is not returned by /collaborators — prepend them
|
||||||
|
// so a solo-owner repo still has an assignable person.
|
||||||
|
if (!collabs.some((c) => c.login === config.owner)) {
|
||||||
|
collabs.unshift({ login: config.owner, name: config.owner })
|
||||||
|
}
|
||||||
|
return collabs
|
||||||
|
},
|
||||||
|
|
||||||
|
async setIssueAssignees(index, logins) {
|
||||||
|
const raw = (await request(`/issues/${index}`, { method: 'PATCH', body: { assignees: logins } })) as RawIssue
|
||||||
|
return normalizeIssue(raw)
|
||||||
|
},
|
||||||
|
|
||||||
|
async setIssueMilestone(index, milestoneId) {
|
||||||
|
// gitea's EditIssueOption takes a milestone id; 0 clears it.
|
||||||
|
const raw = (await request(`/issues/${index}`, {
|
||||||
|
method: 'PATCH',
|
||||||
|
body: { milestone: milestoneId ?? 0 },
|
||||||
|
})) as RawIssue
|
||||||
|
return normalizeIssue(raw)
|
||||||
|
},
|
||||||
|
|
||||||
async createIssue(input) {
|
async createIssue(input) {
|
||||||
const raw = (await request('/issues', {
|
const raw = (await request('/issues', {
|
||||||
method: 'POST',
|
method: 'POST',
|
||||||
|
|||||||
@@ -23,8 +23,15 @@ export type {
|
|||||||
GiteaRequestInit,
|
GiteaRequestInit,
|
||||||
} from './gitea/types.js'
|
} from './gitea/types.js'
|
||||||
|
|
||||||
export { describeChange, planIssueChange, proposalsFor } from './changes/apply-changes-v0.js'
|
export { describeChange, isLabelChange, planIssueChange, proposalsFor, summarizeChange } from './changes/apply-changes-v0.js'
|
||||||
export type { ChangeProposal, IssueChange, LabelPlan, ProposeChangeArgs } from './changes/apply-changes-v0.js'
|
export type {
|
||||||
|
ChangeProposal,
|
||||||
|
IssueChange,
|
||||||
|
LabelChange,
|
||||||
|
LabelPlan,
|
||||||
|
ProposalContext,
|
||||||
|
ProposeChangeArgs,
|
||||||
|
} from './changes/apply-changes-v0.js'
|
||||||
|
|
||||||
export {
|
export {
|
||||||
inferColumnV0,
|
inferColumnV0,
|
||||||
@@ -73,6 +80,7 @@ export type {
|
|||||||
|
|
||||||
export {
|
export {
|
||||||
CALIBRATION_BUCKET_FLOOR,
|
CALIBRATION_BUCKET_FLOOR,
|
||||||
|
calibrationCoverage,
|
||||||
calibrationSamples,
|
calibrationSamples,
|
||||||
COLD_START_THRESHOLD,
|
COLD_START_THRESHOLD,
|
||||||
fitCalibration,
|
fitCalibration,
|
||||||
@@ -80,6 +88,7 @@ export {
|
|||||||
} from './calibration/calibration-v0.js'
|
} from './calibration/calibration-v0.js'
|
||||||
export type {
|
export type {
|
||||||
BucketFit,
|
BucketFit,
|
||||||
|
CalibrationCoverage,
|
||||||
CalibrationModel,
|
CalibrationModel,
|
||||||
CalibrationSample,
|
CalibrationSample,
|
||||||
PersonBias,
|
PersonBias,
|
||||||
|
|||||||
Reference in New Issue
Block a user