Merge pull request 'query_project: implement the standup view (#28)' (#56) from feat/standup-query-view into main
Reviewed-on: #56
This commit is contained in:
@@ -17,10 +17,11 @@ export const QUERY_PROJECT_TOOL: ToolDecl = {
|
||||
properties: {
|
||||
view: {
|
||||
type: 'string',
|
||||
enum: ['focus', 'board', 'calibration', 'issue', 'search'],
|
||||
enum: ['focus', 'board', 'calibration', 'issue', 'search', 'standup'],
|
||||
description:
|
||||
'focus = Now/Next/Later; board = issues by lifecycle column; calibration = estimate-vs-actual; ' +
|
||||
'issue = one issue (needs filters.issueId); search = issues matching filters.query.',
|
||||
'issue = one issue (needs filters.issueId); search = issues matching filters.query; ' +
|
||||
"standup = today's plan + overnight drift + the stalest blocker.",
|
||||
},
|
||||
filters: {
|
||||
type: 'object',
|
||||
|
||||
74
packages/core/src/agent/query-project.test.ts
Normal file
74
packages/core/src/agent/query-project.test.ts
Normal file
@@ -0,0 +1,74 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
|
||||
import { extractLabelFacts } from '../labels/label-schema.js'
|
||||
import type { LifecycleEvent } from '../lifecycle/lifecycle-v0.js'
|
||||
import type { GiteaIssue } from '../gitea/types.js'
|
||||
import { buildProjectView, type ProjectSnapshot } from './query-project.js'
|
||||
|
||||
const asOf = new Date('2026-02-12T00:00:00Z')
|
||||
|
||||
function issue(over: Partial<GiteaIssue>): GiteaIssue {
|
||||
const labels = over.labels ?? ['est/2d']
|
||||
return {
|
||||
number: 1,
|
||||
title: '#1',
|
||||
body: '',
|
||||
state: 'open',
|
||||
labels,
|
||||
facts: extractLabelFacts(labels),
|
||||
milestone: null,
|
||||
assignee: null,
|
||||
assignees: [],
|
||||
createdAt: '2026-02-02T09:00:00Z',
|
||||
updatedAt: '2026-02-02T09:00:00Z',
|
||||
closedAt: null,
|
||||
url: '',
|
||||
...over,
|
||||
}
|
||||
}
|
||||
|
||||
describe('buildProjectView: standup (#28)', () => {
|
||||
it('surfaces schedule drift + a stale blocker, with a per-person plan', () => {
|
||||
// #7 started work 6 working days ago (steeping) and blocks #8; est is 2d → past estimate.
|
||||
const steeping = issue({ number: 7, labels: ['est/2d', 'p/1'], assignee: 'christian' })
|
||||
const blocked = issue({ number: 8, labels: ['est/3d', 'p/2'], assignee: 'stephen' })
|
||||
const timelines: Record<number, LifecycleEvent[]> = {
|
||||
7: [{ type: 'commit', at: '2026-02-04T09:00:00Z' }],
|
||||
}
|
||||
const snap: ProjectSnapshot = { issues: [steeping, blocked], timelines, deps: [{ issue: 8, dependsOn: 7 }] }
|
||||
|
||||
const v = buildProjectView('standup', undefined, snap, asOf) as {
|
||||
plan: { who: string; issue: number; why: string }[]
|
||||
drift: { issue: number; note: string }[]
|
||||
nag: { issue: number; steepingDays: number; blocks: number[] } | null
|
||||
}
|
||||
|
||||
// a stale blocker is nagged, and it's the steeping one that blocks another
|
||||
expect(v.nag).not.toBeNull()
|
||||
expect(v.nag!.issue).toBe(7)
|
||||
expect(v.nag!.steepingDays).toBeGreaterThan(0)
|
||||
expect(v.nag!.blocks).toContain(8)
|
||||
|
||||
// drift caught the past-estimate steep
|
||||
expect(v.drift.some((d) => d.issue === 7)).toBe(true)
|
||||
|
||||
// plan gives an earliest pick per person (both assignees represented)
|
||||
expect(v.plan.map((p) => p.who)).toEqual(expect.arrayContaining(['christian', 'stephen']))
|
||||
// #7 leads its person's plan on the critical path
|
||||
expect(v.plan.find((p) => p.issue === 7)?.why).toContain('critical')
|
||||
})
|
||||
|
||||
it('is calm when nothing is steeping (no nag, empty drift)', () => {
|
||||
const snap: ProjectSnapshot = {
|
||||
issues: [issue({ number: 1, labels: ['est/2d'] })],
|
||||
timelines: {},
|
||||
deps: [],
|
||||
}
|
||||
const v = buildProjectView('standup', undefined, snap, asOf) as {
|
||||
drift: unknown[]
|
||||
nag: unknown | null
|
||||
}
|
||||
expect(v.nag).toBeNull()
|
||||
expect(v.drift).toEqual([])
|
||||
})
|
||||
})
|
||||
@@ -4,9 +4,9 @@
|
||||
* deterministic code (scheduler, lifecycle inference, calibration); the model
|
||||
* only requests a shape and narrates it — it never computes (decisions.md).
|
||||
*
|
||||
* v0 serves focus / board / calibration / issue. The remaining views
|
||||
* (milestone / runway / standup / search) return a `notImplemented` marker so
|
||||
* the model degrades honestly instead of inventing data.
|
||||
* Serves focus / board / calibration / issue / search / standup. The remaining
|
||||
* views (milestone / runway) return a `notImplemented` marker so the model
|
||||
* degrades honestly instead of inventing data.
|
||||
*/
|
||||
|
||||
import { fitCalibration, calibrationSamples } from '../calibration/calibration-v0.js'
|
||||
@@ -121,6 +121,62 @@ function searchView(snap: ProjectSnapshot, filters: QueryFilters) {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Standup — the morning ritual as a compact, model-narratable payload: today's
|
||||
* plan (the scheduler's earliest pick per person), overnight drift (real
|
||||
* anomalies — issues sitting in review or steeping past their estimate), and the
|
||||
* single stalest blocker to nag about. All from deterministic code; the model
|
||||
* narrates it. Satisfies #28's "surfaces schedule drift + at least one stale blocker".
|
||||
*/
|
||||
function standupView(snap: ProjectSnapshot, asOf: Date) {
|
||||
const plan = schedule(toSchedulable(snap.issues), snap.deps)
|
||||
const open = snap.issues.filter((i) => i.state === 'open')
|
||||
const infOf = (i: GiteaIssue) => inferLifecycle(i, snap.timelines[i.number] ?? [], asOf)
|
||||
|
||||
// plan: the earliest scheduled pick per assignee (dependency + priority order)
|
||||
const seen = new Set<string>()
|
||||
const planPicks: { who: string; issue: number; title: string; why: string }[] = []
|
||||
for (const item of plan.items) {
|
||||
const who = open.find((i) => i.number === item.number)?.assignee ?? 'unassigned'
|
||||
if (seen.has(who)) continue
|
||||
seen.add(who)
|
||||
planPicks.push({
|
||||
who,
|
||||
issue: item.number,
|
||||
title: item.title,
|
||||
why: item.critical
|
||||
? 'on the critical path'
|
||||
: item.blocks.length
|
||||
? `blocks ${item.blocks.map((b) => `#${b}`).join(', ')}`
|
||||
: 'next by dependency + priority',
|
||||
})
|
||||
}
|
||||
|
||||
// drift: real overnight anomalies (review-sitting, steeping past estimate)
|
||||
const drift: { issue: number; note: string }[] = []
|
||||
for (const i of open) {
|
||||
const inf = infOf(i)
|
||||
if (inf.column === 'review') drift.push({ issue: i.number, note: `#${i.number} is sitting in review` })
|
||||
else if (inf.steepingDays != null && inf.steepingDays > (i.facts.estimateDays ?? 2))
|
||||
drift.push({
|
||||
issue: i.number,
|
||||
note: `#${i.number} has steeped ${inf.steepingDays}d past its ${i.facts.estimateDays ?? 2}d estimate`,
|
||||
})
|
||||
}
|
||||
|
||||
// nag: the single longest-steeping open issue + what it blocks
|
||||
let nag: { issue: number; steepingDays: number; blocks: number[] } | null = null
|
||||
for (const i of open) {
|
||||
const inf = infOf(i)
|
||||
if (inf.steepingDays == null) continue
|
||||
if (!nag || inf.steepingDays > nag.steepingDays) {
|
||||
nag = { issue: i.number, steepingDays: inf.steepingDays, blocks: plan.items.find((it) => it.number === i.number)?.blocks ?? [] }
|
||||
}
|
||||
}
|
||||
|
||||
return { date: asOf.toISOString().slice(0, 10), plan: planPicks.slice(0, 5), drift: drift.slice(0, 5), nag }
|
||||
}
|
||||
|
||||
/** Build the compact payload for one view. Unknown/unbuilt views return a marker. */
|
||||
export function buildProjectView(
|
||||
view: ProjectView,
|
||||
@@ -140,6 +196,8 @@ export function buildProjectView(
|
||||
return issueView(snap, f, asOf)
|
||||
case 'search':
|
||||
return searchView(snap, f)
|
||||
case 'standup':
|
||||
return standupView(snap, asOf)
|
||||
default:
|
||||
return { notImplemented: view }
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user