6198f21d9a
The first write path. Read, forecast, and calibration were all real; now you can
*manage* CommiTea from CommiTea. Estimates/priority are exclusive label axes, so
a change is a label swap — proposed, approved, then written. Nothing is assumed.
core (@commitea/core):
- planIssueChange(current, change): pure diff planner — swaps the est/*|p/* axis,
clears on null, dedups a doubled axis; returns the resulting label set + a
before/after diff + noop flag. describeChange() renders "est/2d → est/5d".
- request() seam extended for writes (method/body, JSON, 204). client gains
listLabels() (name→id) and setIssueLabels() (PUT /issues/{n}/labels).
app:
- main bridge gitea:applyChange — resolves plan.labels → ids (cached, refetch on
miss), PUTs, returns the plan + fresh issue. Token never leaves main.
- preload + global.d.ts expose applyChange; useBacklog returns a refetch so a
write re-reconciles the board + forecast.
- Issue screen: an Adjust button (shown only when configured) opens a
propose-approve Dialog — estimate/priority pickers, live "est/3d → est/8d"
consequence, Apply/Cancel. AppShell wires it, reflects new labels on the open
issue immediately, and refetches.
Verified: 83 core tests green (7 apply-changes + 2 client-write new), desktop
typecheck clean, 14 fixture e2e green. Live spec exercises propose + CANCEL (no
mutation); the real PUT was verified once manually (change #2 est/3d→est/8d→200,
reverted clean). Icon: pencil (no sliders-horizontal in the set).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
55 lines
2.4 KiB
TypeScript
55 lines
2.4 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import { describeChange, type IssueChange, planIssueChange } from './apply-changes-v0.js'
|
|
|
|
describe('planIssueChange', () => {
|
|
it('swaps the estimate label, keeping non-axis labels', () => {
|
|
const plan = planIssueChange(['est/2d', 'p/1', 'backend'], { kind: 'reestimate', issue: 1, estimate: 'est/5d' })
|
|
expect(plan.removed).toEqual(['est/2d'])
|
|
expect(plan.added).toEqual(['est/5d'])
|
|
expect(plan.labels).toEqual(['p/1', 'backend', 'est/5d'])
|
|
expect(plan.noop).toBe(false)
|
|
})
|
|
|
|
it('adds an estimate when none was set', () => {
|
|
const plan = planIssueChange(['p/2'], { kind: 'reestimate', issue: 1, estimate: 'est/1d' })
|
|
expect(plan.removed).toEqual([])
|
|
expect(plan.added).toEqual(['est/1d'])
|
|
expect(plan.labels).toEqual(['p/2', 'est/1d'])
|
|
})
|
|
|
|
it('clears the axis when the target is null', () => {
|
|
const plan = planIssueChange(['est/3d', 'p/1'], { kind: 'reprioritize', issue: 1, priority: null })
|
|
expect(plan.removed).toEqual(['p/1'])
|
|
expect(plan.added).toEqual([])
|
|
expect(plan.labels).toEqual(['est/3d'])
|
|
})
|
|
|
|
it('is a noop when the target already holds the axis alone', () => {
|
|
const plan = planIssueChange(['est/2d', 'p/1'], { kind: 'reestimate', issue: 1, estimate: 'est/2d' })
|
|
expect(plan.noop).toBe(true)
|
|
expect(plan.labels).toEqual(['p/1', 'est/2d'])
|
|
})
|
|
|
|
it('cleans up a duplicated axis down to the target', () => {
|
|
// two est/* labels — the change collapses to one
|
|
const plan = planIssueChange(['est/2d', 'est/5d', 'p/1'], { kind: 'reestimate', issue: 1, estimate: 'est/5d' })
|
|
expect(plan.removed).toEqual(['est/2d'])
|
|
expect(plan.added).toEqual([]) // est/5d already present
|
|
expect(plan.labels).toEqual(['p/1', 'est/5d'])
|
|
expect(plan.noop).toBe(false)
|
|
})
|
|
|
|
it('reprioritize only touches the priority axis', () => {
|
|
const plan = planIssueChange(['est/2d', 'p/3'], { kind: 'reprioritize', issue: 1, priority: 'p/1' })
|
|
expect(plan.labels).toEqual(['est/2d', 'p/1'])
|
|
})
|
|
|
|
it('describeChange renders the diff', () => {
|
|
const change: IssueChange = { kind: 'reestimate', issue: 1, estimate: 'est/5d' }
|
|
expect(describeChange(planIssueChange(['est/2d'], change))).toBe('est/2d → est/5d')
|
|
expect(describeChange(planIssueChange(['p/1'], { kind: 'reprioritize', issue: 1, priority: null }))).toBe('p/1 → ∅')
|
|
expect(describeChange(planIssueChange(['est/5d'], change))).toBe('no change')
|
|
})
|
|
})
|